Skip to content

Comments

Implement batched gemm bias permute for RDNA4#3534

Merged
ErwinTerpstra merged 18 commits intodevelopfrom
eterpstr/96-implement-device_batched_gemm_bias_permute-for-rdna4
Jan 17, 2026
Merged

Implement batched gemm bias permute for RDNA4#3534
ErwinTerpstra merged 18 commits intodevelopfrom
eterpstr/96-implement-device_batched_gemm_bias_permute-for-rdna4

Conversation

@ErwinTerpstra
Copy link
Contributor

@ErwinTerpstra ErwinTerpstra commented Jan 8, 2026 •
edited
Loading

Proposed changes

This MR implements batched gemm bias permute for RDNA3/4. In practice, this is a multidimensional contraction operation. The MR contains the following:

  • Profiler and test infrastructure for the batched contraction instances, as this was not implemented yet for XDL versions
  • Device struct for batched contraction using WMMA instructions (device_batched_contraction_multiple_d_wmma_cshuffle_v3)
  • Changes to the GridwiseGemmWmmaCShuffleV3 to allow passing in non-naive grid descriptors

Note that support for different dimensions and D tensor configurations is very limited at the moment. More scaffolding would be needed to add generic support for variable number of dimensions, but with this limited implementation there is at least parity with the XDL versions.

Checklist

Please put an x into the boxes that apply. You can also fill these out after creating the PR. If you're not sure, please don't hesitate to ask.

  • I have added tests relevant to the introduced functionality, and the unit tests are passing locally
  • I have added the test to REGRESSION_TESTS list defined at the top of CMakeLists.txt in tests/CMakeLists.txt, IF the test takes more than 30 seconds to run.
  • I have added inline documentation which enables the maintainers with understanding the motivation
  • I have removed the stale documentation which is no longer relevant after this pull request
  • (If this change is user-facing) I have added release notes which provide the end users with a brief summary of the improvement from this pull request
  • I have run clang-format on all changed files
  • Any dependent changes have been merged

Discussion

If this is a relatively large or complex change, feel free to start a discussion by explaining why you chose the solution you did and what alternatives you considered

@EnricoDeg
Copy link
Contributor

EnricoDeg commented Jan 14, 2026

Can you also add an example for wmma?

EnricoDeg
EnricoDeg reviewed Jan 14, 2026
View reviewed changes
Copy link
Contributor

@EnricoDeg EnricoDeg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work !

ApoorvaKalyani
ApoorvaKalyani reviewed Jan 15, 2026
View reviewed changes
Copy link
Contributor

@ApoorvaKalyani ApoorvaKalyani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!
I also think we need more instances and we need to reverify the tests for those.

@ErwinTerpstra
Copy link
Contributor Author

ErwinTerpstra commented Jan 15, 2026

@EnricoDeg @ApoorvaKalyani Thank you for the reviews. I processed the comments, added an example and added a couple of instances for both v1 and v3 pipelines. Let me know if there's still something you'd like to see changed.

@EnricoDeg
Copy link
Contributor

EnricoDeg commented Jan 16, 2026

@EnricoDeg @ApoorvaKalyani Thank you for the reviews. I processed the comments, added an example and added a couple of instances for both v1 and v3 pipelines. Let me know if there's still something you'd like to see changed.

LGTM

@ApoorvaKalyani
Copy link
Contributor

ApoorvaKalyani commented Jan 16, 2026

@EnricoDeg @ApoorvaKalyani Thank you for the reviews. I processed the comments, added an example and added a couple of instances for both v1 and v3 pipelines. Let me know if there's still something you'd like to see changed.

LGTM

Great!

@ErwinTerpstra ErwinTerpstra marked this pull request as ready for review January 16, 2026 12:41
@ErwinTerpstra ErwinTerpstra merged commit fe40a5d into develop Jan 17, 2026
22 checks passed
@ErwinTerpstra ErwinTerpstra deleted the eterpstr/96-implement-device_batched_gemm_bias_permute-for-rdna4 branch January 17, 2026 07:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@EnricoDeg EnricoDeg EnricoDeg approved these changes

@illsilin illsilin illsilin approved these changes

@ApoorvaKalyani ApoorvaKalyani ApoorvaKalyani approved these changes

@carlushuang carlushuang Awaiting requested review from carlushuang carlushuang is a code owner

@qianfengz qianfengz Awaiting requested review from qianfengz qianfengz is a code owner

@aosewski aosewski Awaiting requested review from aosewski aosewski is a code owner

@poyenc poyenc Awaiting requested review from poyenc poyenc is a code owner

@geyyer geyyer Awaiting requested review from geyyer geyyer is a code owner

@bartekxk bartekxk Awaiting requested review from bartekxk bartekxk is a code owner

@andriy-ca andriy-ca Awaiting requested review from andriy-ca andriy-ca is a code owner

@afagaj afagaj Awaiting requested review from afagaj afagaj is a code owner

@asleepzzz asleepzzz Awaiting requested review from asleepzzz asleepzzz is a code owner

@ThomasNing ThomasNing Awaiting requested review from ThomasNing ThomasNing is a code owner

@coderfeli coderfeli Awaiting requested review from coderfeli coderfeli is a code owner

@cgmillette cgmillette Awaiting requested review from cgmillette cgmillette is a code owner

@shumway shumway Awaiting requested review from shumway shumway is a code owner

@vidyasagar-amd vidyasagar-amd Awaiting requested review from vidyasagar-amd vidyasagar-amd is a code owner

@vpietila-amd vpietila-amd Awaiting requested review from vpietila-amd vpietila-amd is a code owner

@Snektron Snektron Awaiting requested review from Snektron Snektron is a code owner

@tenpercent tenpercent Awaiting requested review from tenpercent tenpercent is a code owner

Assignees

No one assigned

Labels

organization: streamhpc

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ErwinTerpstra @EnricoDeg @ApoorvaKalyani @illsilin